Merged
Conversation
6 tasks
|
Libtask.jl documentation for PR #219 is available at: |
Member
Author
|
@Technici4n, would you be interested in reviewing? No pressure! It's just we don't have anybody else who knows the IR stuff 😄. |
Contributor
|
Sorry I really don't have the bandwidth atm 😅 But you really overestimate my knowledge of IR :) |
Member
Author
|
Haha that's totally fine! I will ship it and take responsibility for any bugs 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211.
The issue here is that for a function like this
Libtask would transform the original IR
to
The issue is the line
(Libtask.set_ref_at!)(_1, 1, Main.a)::Any-- becauseMain.ais not a const global, it for some reason can't be passed as an argument to a function (the error is thrown here https://github.com/JuliaLang/julia/blob/53a02c0720cdc5d7fc0f35447886dd14bb2491a6/base/compiler/ssair/verify.jl#L58-L62). So this PR fixes it by first assigning it to an SSA ID, and then passing that ID toset_ref_at!instead, which gives us this: